Option for other icon libraries #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaulted with both Glyphicon and Font Awesome libraries. Backwards compatible with old syntax
|
@sman591 thanks, we definetely want this to be part of bootstrap markdown option. It would be great if you can demonstrate this within github page branch as well? |
|
Sure, I'll go ahead and update that tonight |
Reflects same naming convention as the "autofocus" option
|
👍 I use FontAwesome everywhere, so this would help a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glyphicons are great and all, but I know multiple websites use other icon libraries (most commonly Font Awesome). Simple implementation:
Old icon syntax
icon: 'glyphicon glyphicon-bold'
New icon syntax
icon: { glyph: 'glyphicon glyphicon-bold', fa: 'fa fa-bold' }
Choosing icon library
The default icon library is glyphicons, as that is the default with Bootstrap. Too change to Font Awesome, for example:
$('textarea').markdown({iconLibrary: 'fa'})
Of course, still backwards compatible with the old syntax.